Add otelaws middleware to support trace propagation in the AWS SDK v2 module #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukestoward
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
|
|
lukestoward
changed the title
Aneurysm9
reviewed
Oct 11, 2022
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/aws.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/aws.go
Outdated
Show resolved
Hide resolved
|
@Aneurysm9 I have added tests and made the propagator configurable. Please could you re-review, thanks. |
Aneurysm9
approved these changes
Oct 11, 2022
dmathieu
approved these changes
Oct 12, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2856 +/- ##
=====================================
Coverage 69.2% 69.3%
=====================================
Files 145 145
Lines 6712 6729 +17
=====================================
+ Hits 4651 4667 +16
- Misses 1947 1948 +1
Partials 114 114
|
|
@dmathieu I've rebased and fixed the linter complaints. Please could you re-trigger the workflow. Thanks. |
|
Awesome, looks like all checks are passing. Rather than keep rebasing, please let me know when this can be merged and I will rebase ASAP. Please let me know if anything else is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
otelawsinstrumentation module does not propagate tracing information as part of any AWS SDK v2 call. To support this, I've added a new finalizer middleware that uses the provided text map propagator (or global using the OTel API) and injects the trace information into the request headers.This functionality is really important for me as I am heavily dependent on the AWS SDK v2 Go module and, most importantly, tracing across AWS service calls.